[Mac] Fix a crash in the cookies manager that was caused by an invalid selection.

[Mac] Fix a crash in the cookies manager that was caused by an invalid selection.

XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.

BUG=32627
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36796

[Robert Sesek, 2010-01-21 04:29:02]

This is P0. It'll need to be merged to 302.

[John Grabowski, 2010-01-21 06:14:47]

Update TEST= description in CL with a sanity check.  E.g.
- select one thing --> make sure delete enabled
- select 2 things --> make sure delete DISabled
- select one thing again --> make sure delete enabled, and delete works

Yes, it's covered by the unit test (yay) but the sanity check makes sure the
change got rolled into the right build.

Once landed let me know and I'll roll it into the right branch.

http://codereview.chromium.org/546102/diff/3001/3003
File chrome/browser/cocoa/cookies_window_controller.h (right):

http://codereview.chromium.org/546102/diff/3001/3003#newcode86
chrome/browser/cocoa/cookies_window_controller.h:86: // Whether or not the
"Remove" button should be enabled.
super-picky nit: Google coding standard is to use complete sentences in
comments.  This is arguably not a sentence.

http://codereview.chromium.org/546102/diff/3001/3004
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/546102/diff/3001/3004#newcode266
chrome/browser/cocoa/cookies_window_controller.mm:266: -
(void)outlineViewSelectionDidChange:(NSNotification*)notif {
Add comment like "delegate callback for NSBlahBlah"

http://codereview.chromium.org/546102/diff/3001/3004#newcode269
chrome/browser/cocoa/cookies_window_controller.mm:269: if ([[treeController_
selectedObjects] count] != 1U) {
perhaps DCHECK() this as well.

http://codereview.chromium.org/546102/diff/3001/3005
File chrome/browser/cocoa/cookies_window_controller_unittest.mm (right):

http://codereview.chromium.org/546102/diff/3001/3005#newcode437
chrome/browser/cocoa/cookies_window_controller_unittest.mm:437:
TEST_F(CookiesWindowControllerTest, RemoveButtonEnabled) {
Thanks so much for adding this

[John Grabowski, 2010-01-21 06:15:02]

Forgot to say: LGTM

On 2010/01/21 06:14:47, John Grabowski wrote:
> Update TEST= description in CL with a sanity check.  E.g.
> - select one thing --> make sure delete enabled
> - select 2 things --> make sure delete DISabled
> - select one thing again --> make sure delete enabled, and delete works
> 
> Yes, it's covered by the unit test (yay) but the sanity check makes sure the
> change got rolled into the right build.
> 
> Once landed let me know and I'll roll it into the right branch.
> 
> http://codereview.chromium.org/546102/diff/3001/3003
> File chrome/browser/cocoa/cookies_window_controller.h (right):
> 
> http://codereview.chromium.org/546102/diff/3001/3003#newcode86
> chrome/browser/cocoa/cookies_window_controller.h:86: // Whether or not the
> "Remove" button should be enabled.
> super-picky nit: Google coding standard is to use complete sentences in
> comments.  This is arguably not a sentence.
> 
> http://codereview.chromium.org/546102/diff/3001/3004
> File chrome/browser/cocoa/cookies_window_controller.mm (right):
> 
> http://codereview.chromium.org/546102/diff/3001/3004#newcode266
> chrome/browser/cocoa/cookies_window_controller.mm:266: -
> (void)outlineViewSelectionDidChange:(NSNotification*)notif {
> Add comment like "delegate callback for NSBlahBlah"
> 
> http://codereview.chromium.org/546102/diff/3001/3004#newcode269
> chrome/browser/cocoa/cookies_window_controller.mm:269: if ([[treeController_
> selectedObjects] count] != 1U) {
> perhaps DCHECK() this as well.
> 
> http://codereview.chromium.org/546102/diff/3001/3005
> File chrome/browser/cocoa/cookies_window_controller_unittest.mm (right):
> 
> http://codereview.chromium.org/546102/diff/3001/3005#newcode437
> chrome/browser/cocoa/cookies_window_controller_unittest.mm:437:
> TEST_F(CookiesWindowControllerTest, RemoveButtonEnabled) {
> Thanks so much for adding this

[Robert Sesek, 2010-01-21 19:20:46]

http://codereview.chromium.org/546102/diff/3001/3003
File chrome/browser/cocoa/cookies_window_controller.h (right):

http://codereview.chromium.org/546102/diff/3001/3003#newcode86
chrome/browser/cocoa/cookies_window_controller.h:86: // Whether or not the
"Remove" button should be enabled.
On 2010/01/21 06:14:47, John Grabowski wrote:
> super-picky nit: Google coding standard is to use complete sentences in
> comments.  This is arguably not a sentence.

Done.

http://codereview.chromium.org/546102/diff/3001/3004
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/546102/diff/3001/3004#newcode266
chrome/browser/cocoa/cookies_window_controller.mm:266: -
(void)outlineViewSelectionDidChange:(NSNotification*)notif {
On 2010/01/21 06:14:47, John Grabowski wrote:
> Add comment like "delegate callback for NSBlahBlah" 
> 

I think the selector name is sufficient.

http://codereview.chromium.org/546102/diff/3001/3004#newcode269
chrome/browser/cocoa/cookies_window_controller.mm:269: if ([[treeController_
selectedObjects] count] != 1U) {
On 2010/01/21 06:14:47, John Grabowski wrote:
> perhaps DCHECK() this as well.

Done.