Issue 546081: Adds local storage nodes to cookie tree model and cookies view. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546081: Adds local storage nodes to cookie tree model and cookies view. ... (Closed)

Created:
10 years, 11 months ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
bulach_

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds local storage nodes to cookie tree model and cookies view. BUG=none TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame. Landing for Marcus Original CL: http://codereview.chromium.org/523139/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36644

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+597 lines, -66 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.h	View	10 chunks	+91 lines, -10 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View	7 chunks	+113 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/options/cookies_view.h	View	5 chunks	+21 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/options/cookies_view.cc	View	7 chunks	+99 lines, -31 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_context.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_context.cc	View	4 chunks	+43 lines, -5 lines	0 comments	Download
M	chrome/browser/views/options/cookies_view.h	View	4 chunks	+56 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/cookies_view.cc	View	8 chunks	+150 lines, -13 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bulach_

10 years, 11 months ago (2010-01-20 14:08:08 UTC) #2

On 2010/01/19 22:29:06, Jeremy Orlow wrote:
> 

Thanks Jeremy!
Minor nit: the original CL mentioned in the description should be:
http://codereview.chromium.org/523139/show

Expand Messages | Collapse Messages