Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 546075: First step of refactoring expression contexts in the toplevel code... (Closed)

Created:
10 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

First step of refactoring expression contexts in the toplevel code generator. Contexts are no longer stored in the AST but in the code generator's state. This means that the running the code generator selector is not required to use the toplevel code generator (for instance, if we already know that we can and should use it). Committed: http://code.google.com/p/v8/source/detail?r=3645

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -434 lines) Patch
M src/arm/fast-codegen-arm.cc View 25 chunks +39 lines, -48 lines 0 comments Download
M src/ast.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler.cc View 19 chunks +64 lines, -207 lines 1 comment Download
M src/fast-codegen.h View 2 chunks +52 lines, -4 lines 0 comments Download
M src/fast-codegen.cc View 7 chunks +56 lines, -74 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 25 chunks +38 lines, -47 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 25 chunks +39 lines, -48 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 11 months ago (2010-01-19 10:11:10 UTC) #1
fschneider
10 years, 11 months ago (2010-01-19 12:36:10 UTC) #2
LGTM.

http://codereview.chromium.org/546075/diff/1/5
File src/compiler.cc (right):

http://codereview.chromium.org/546075/diff/1/5#newcode757
src/compiler.cc:757: if (!var->is_global()) {
This is clearer than before and should be fine.

It just seems confusing that VariableProxy::AsVariable() checks var_ for NULL
explicitly. Is there any case where it  still can be NULL?

Powered by Google App Engine
This is Rietveld 408576698