Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 546068: Fix GC bug... (Closed)

Created:
10 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix GC bug The patching of the receiver added in r3616 was not GC-safe and could leave a failure object in place of the receiver if allocation of the wrapper JS object failed. Committed: http://code.google.com/p/v8/source/detail?r=3633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 11 months ago (2010-01-18 14:02:51 UTC) #1
Lasse Reichstein
10 years, 11 months ago (2010-01-18 14:13:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698