Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 546006: Some cleanup of the toplevel code generator:... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/fast-codegen-arm.cc » ('j') | src/arm/fast-codegen-arm.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 VirtualFrame::SpilledScope spilled_scope; 607 VirtualFrame::SpilledScope spilled_scope;
608 Comment cmnt(masm_, "[ LoadReference"); 608 Comment cmnt(masm_, "[ LoadReference");
609 Expression* e = ref->expression(); 609 Expression* e = ref->expression();
610 Property* property = e->AsProperty(); 610 Property* property = e->AsProperty();
611 Variable* var = e->AsVariableProxy()->AsVariable(); 611 Variable* var = e->AsVariableProxy()->AsVariable();
612 612
613 if (property != NULL) { 613 if (property != NULL) {
614 // The expression is either a property or a variable proxy that rewrites 614 // The expression is either a property or a variable proxy that rewrites
615 // to a property. 615 // to a property.
616 LoadAndSpill(property->obj()); 616 LoadAndSpill(property->obj());
617 // We use a named reference if the key is a literal symbol, unless it is 617 if (property->key()->IsPropertyName()) {
618 // a string that can be legally parsed as an integer. This is because
619 // otherwise we will not get into the slow case code that handles [] on
620 // String objects.
621 Literal* literal = property->key()->AsLiteral();
622 uint32_t dummy;
623 if (literal != NULL &&
624 literal->handle()->IsSymbol() &&
625 !String::cast(*(literal->handle()))->AsArrayIndex(&dummy)) {
626 ref->set_type(Reference::NAMED); 618 ref->set_type(Reference::NAMED);
627 } else { 619 } else {
628 LoadAndSpill(property->key()); 620 LoadAndSpill(property->key());
629 ref->set_type(Reference::KEYED); 621 ref->set_type(Reference::KEYED);
630 } 622 }
631 } else if (var != NULL) { 623 } else if (var != NULL) {
632 // The expression is a variable proxy that does not rewrite to a 624 // The expression is a variable proxy that does not rewrite to a
633 // property. Global variables are treated as named property references. 625 // property. Global variables are treated as named property references.
634 if (var->is_global()) { 626 if (var->is_global()) {
635 LoadGlobal(); 627 LoadGlobal();
(...skipping 5930 matching lines...) Expand 10 before | Expand all | Expand 10 after
6566 ASSERT((static_cast<unsigned>(cc_) >> 26) < (1 << 16)); 6558 ASSERT((static_cast<unsigned>(cc_) >> 26) < (1 << 16));
6567 int nnn_value = (never_nan_nan_ ? 2 : 0); 6559 int nnn_value = (never_nan_nan_ ? 2 : 0);
6568 if (cc_ != eq) nnn_value = 0; // Avoid duplicate stubs. 6560 if (cc_ != eq) nnn_value = 0; // Avoid duplicate stubs.
6569 return (static_cast<unsigned>(cc_) >> 26) | nnn_value | (strict_ ? 1 : 0); 6561 return (static_cast<unsigned>(cc_) >> 26) | nnn_value | (strict_ ? 1 : 0);
6570 } 6562 }
6571 6563
6572 6564
6573 #undef __ 6565 #undef __
6574 6566
6575 } } // namespace v8::internal 6567 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/fast-codegen-arm.cc » ('j') | src/arm/fast-codegen-arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698