Issue 5460002: Add a missing comment to a switch I recently added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5460002: Add a missing comment to a switch I recently added. (Closed)

Created:
10 years ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a missing comment to a switch I recently added. BUG=63511 TEST=none TBR=erikkay@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67888

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/common/chrome_switches.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

10 years ago (2010-12-02 00:50:37 UTC) #2

LGTM

On Wed, Dec 1, 2010 at 11:35 AM, <asargent@chromium.org> wrote:

> Reviewers: Erik Kay,
>
> Message:
> FYI, TBR
>
> Description:
> Add a missing comment to a switch I recently added.
>
> BUG=63511
> TEST=none
>
> TBR=erikkay@chromium.org
>
>
> Please review this at http://codereview.chromium.org/5460002/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/common/chrome_switches.cc
>
>
> Index: chrome/common/chrome_switches.cc
> ===================================================================
> --- chrome/common/chrome_switches.cc    (revision 67778)
> +++ chrome/common/chrome_switches.cc    (working copy)
> @@ -59,6 +59,7 @@
>  // The URL to use for the gallery link in the app launcher.
>  const char kAppsGalleryURL[]                = "apps-gallery-url";
>
> +// The update url used by gallery/webstore extensions.
>  const char kAppsGalleryUpdateURL[]          = "apps-gallery-update-url";
>
>  // Disable throbber for extension apps.
>
>
>

Expand Messages | Collapse Messages