Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/autofill/autofill_dialog.h

Issue 545175: Add the ability to save and remove AutoFill profiles from the AutoFillDialog.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_dialog.h
===================================================================
--- chrome/browser/autofill/autofill_dialog.h (revision 36779)
+++ chrome/browser/autofill/autofill_dialog.h (working copy)
@@ -14,10 +14,11 @@
// the user has applied changes to the AutoFill profile data.
class AutoFillDialogObserver {
public:
- // The user has confirmed changes by clicking "Apply" or "OK".
+ // The user has confirmed changes by clicking "Apply" or "OK". Any of the
+ // parameters may be NULL.
virtual void OnAutoFillDialogApply(
- const std::vector<AutoFillProfile>& profiles,
- const std::vector<CreditCard>& credit_cards) = 0;
+ std::vector<AutoFillProfile>* profiles,
+ std::vector<CreditCard>* credit_cards) = 0;
protected:
virtual ~AutoFillDialogObserver() {}
@@ -29,8 +30,12 @@
// changes made to the profile information through the dialog should be
// transferred back into |profiles| and |credit_cards|. |observer| will be
// notified by OnAutoFillDialogAccept when the user has applied changes.
+//
+// The PersonalDataManager owns the contents of these vectors. The lifetime of
+// the contents is until the PersonalDataManager replaces them with new data
+// whenever the web database is updated.
void ShowAutoFillDialog(AutoFillDialogObserver* observer,
- const std::vector<AutoFillProfile>& profiles,
- const std::vector<CreditCard>& credit_cards);
+ const std::vector<AutoFillProfile*>& profiles,
+ const std::vector<CreditCard*>& credit_cards);
#endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_DIALOG_H_
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698