Issue 545130: ARM build: replacement postinst for netbase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545130: ARM build: replacement postinst for netbase (Closed)

Created:
10 years, 11 months ago by adlr

Modified:
9 years ago

Reviewers:
tedbo

CC:
chromium-os-reviews_googlegroups.com

Visibility:
Public.

Description

ARM build: replacement postinst for netbase

Patch Set 1 #

Total comments: 1

Patch Set 2 : rewrite to do less work #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
A	src/package_scripts/netbase.postinst	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/package_scripts/package.whitelist	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/scripts/install_packages.sh	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tedbo

10 years, 11 months ago (2010-01-20 06:34:45 UTC) #3

LGTM

http://codereview.chromium.org/545130/diff/1/2
File src/package_scripts/netbase.postinst (right):

http://codereview.chromium.org/545130/diff/1/2#newcode15
src/package_scripts/netbase.postinst:15: if [ -f" ${ROOT}/etc/hosts" ] && \
It looks like the spacing is messed up in '[ -f" ${ROOT}...'

Expand Messages | Collapse Messages