--issue=523108

chrome/renderer/render_view.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
 #define CHROME_RENDERER_RENDER_VIEW_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 418 matching lines @@
 
   // Sends a message and runs a nested message loop.
   bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);
 
   // Called when the "idle" user script state has been reached. See
   // UserScript::DOCUMENT_IDLE.
   void OnUserScriptIdleTriggered(WebKit::WebFrame* frame);
 
   PageTranslator* page_translator() const { return page_translator_.get(); }
 
-  // Returns the ISO 639_1 language code of the current page
-  // (ex: en, fr, zh...).  Returns 'unknown' if the language could not be
-  // determined.
+  // Returns the ISO 639 language code of the current page (e.g. en, fr, zh).
+  // If ISO 639-1 code is not available for the language, ISO 639-2 3-letter code
+  // will be returned (e.g. kha for Khasi and und for undtermined). For traditional
+  // Chinse, 'zh-TW' will be returned while for simplified Chinse, 'zh' will be
+  // returned.
+  // TODO(jungshik): Make it return 'he' (the correct ISO 639 code for Hebrew)
+  // instead of the obsolete 'iw'. Perhaps, it's also better to return 'zh-Hans'
+  // (or 'zh-CN') for Simplified Chinese instead of 'zh' to be aligned with
+  // 'zh-TW' for Traditional Chinse.
   std::string DetectLanguage();
 
  protected:
   // RenderWidget overrides:
   virtual void Close();
   virtual void OnResize(const gfx::Size& new_size,
                         const gfx::Rect& resizer_rect);
   virtual void DidPaint();
   virtual void DidHandleKeyEvent();
 
@@ skipping 561 matching lines @@
   int64 session_storage_namespace_id_;
 
   // Page translation related objects.
   TextTranslatorImpl text_translator_;
   scoped_ptr<PageTranslator> page_translator_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderView);
 };
 
 #endif  // CHROME_RENDERER_RENDER_VIEW_H_