Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 545118: Re-Fix DebugEvaluateWithoutStack test on Windows (Closed)

Created:
10 years, 11 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Re-Fix DebugEvaluateWithoutStack test on Windows Committed: http://code.google.com/p/v8/source/detail?r=3654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/cctest/test-debug.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Rybin
Gentlemen, I'm sorry, the previous fix was really bad, though it passes on Linux. I ...
10 years, 11 months ago (2010-01-19 15:33:59 UTC) #1
Mads Ager (chromium)
OK, LGTM
10 years, 11 months ago (2010-01-19 15:39:06 UTC) #2
Søren Thygesen Gjesse
10 years, 11 months ago (2010-01-19 15:43:44 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698