Issue 545116: Added Extensible property to objects and made methods for extracting and sett...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545116: Added Extensible property to objects and made methods for extracting and sett... (Closed)

Created:
10 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added Extensible property to objects and made methods for extracting and setting it. Also added one method to runtime to get the extensible value Additionally, added a check on the number of arguments in the start of GetOwnProperty. Committed: http://code.google.com/p/v8/source/detail?r=3646

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
M	src/objects.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/545116/diff/1/3 File src/runtime.h (right): http://codereview.chromium.org/545116/diff/1/3#newcode71 src/runtime.h:71: F(Extensible, 1, 1) \ Maybe call this IsExtensible.

10 years, 11 months ago (2010-01-19 12:13:27 UTC) #2

Rico

10 years, 11 months ago (2010-01-19 12:56:21 UTC) #3

http://codereview.chromium.org/545116/diff/1/3
File src/runtime.h (right):

http://codereview.chromium.org/545116/diff/1/3#newcode71
src/runtime.h:71: F(Extensible, 1, 1) \
On 2010/01/19 12:13:27, Søren Gjesse wrote:
> Maybe call this IsExtensible.

Done.

Expand Messages | Collapse Messages