Issue 545109: Added ES5 conform tests for getOwnPropertyNames....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545109: Added ES5 conform tests for getOwnPropertyNames.... (Closed)

Created:
10 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added ES5 conform tests for getOwnPropertyNames. Most of the test cases fail as the different objects according to the tests can not have additional properties attached to them. I will file a bug report on the es5 conform site as they should allow this. Some of the test fails because we still miss some of the es5 features used. Committed: http://code.google.com/p/v8/source/detail?r=3642

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -1 line)			Patch
	M	test/es5conform/es5conform.status	View		2 chunks	+111 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM I think you should raise a bug to track the missing pieces of getOwnPropertyNames.

10 years, 11 months ago (2010-01-18 14:27:42 UTC) #2

Rico

10 years, 11 months ago (2010-01-19 08:22:44 UTC) #3

On 2010/01/18 14:27:42, Søren Gjesse wrote:
> LGTM
> 
> I think you should raise a bug to track the missing pieces of
> getOwnPropertyNames.
Done

Expand Messages | Collapse Messages