Issue 545108: X64 implementation of native ascii string compare.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545108: X64 implementation of native ascii string compare. (Closed)

Created:
10 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

X64 implementation of native ascii string compare.

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -4 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	5 chunks	+191 lines, -3 lines	2 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM I like giving scratch registers names. In a separate change: Consider porting some of ...

10 years, 11 months ago (2010-01-18 09:58:01 UTC) #2

Lasse Reichstein

10 years, 11 months ago (2010-01-18 10:33:02 UTC) #3

I'll make a macro for testing whether two elements are
non-sequential-ascii-strings immediately. I disliked the duplicated code
already.

http://codereview.chromium.org/545108/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/545108/diff/1/3#newcode8274
src/x64/codegen-x64.cc:8274: __ Move(rax, Smi::FromInt(0));
Fixed

Expand Messages | Collapse Messages