Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 545080: Lift filtering of the test higher as otherwise we can get... (Closed)

Created:
10 years, 11 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Lift filtering of the test higher as otherwise we can get empty list of tests to run after the filtering and would actually die with division by 0. And there was a type (|c| instead of |case|) which is fixed too. Committed: http://code.google.com/p/v8/source/detail?r=3629

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/test.py View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
10 years, 11 months ago (2010-01-15 13:24:20 UTC) #1
Mads Ager (chromium)
10 years, 11 months ago (2010-01-15 13:51:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698