Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: src/platform/update_engine/download_action_unittest.cc

Issue 545072: AU: Gut code for old updater. New protobuf for v2 updater. (Closed)
Patch Set: better comments Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/update_engine/download_action_unittest.cc
diff --git a/src/platform/update_engine/download_action_unittest.cc b/src/platform/update_engine/download_action_unittest.cc
index 57e8d7e546dd929ce63005ef83ca3f45ab2166ae..014d3b771af87805864dd79afd04bf29fc3b3f4a 100644
--- a/src/platform/update_engine/download_action_unittest.cc
+++ b/src/platform/update_engine/download_action_unittest.cc
@@ -80,7 +80,7 @@ void TestWithData(const vector<char>& data, bool compress) {
// takes ownership of passed in HttpFetcher
InstallPlan install_plan(compress, "",
OmahaHashCalculator::OmahaHashOfData(use_data),
- compress ? "" : path, compress ? path : "");
+ path);
ObjectFeederAction<InstallPlan> feeder_action;
feeder_action.set_obj(install_plan);
DownloadAction download_action(new MockHttpFetcher(&use_data[0],
@@ -157,7 +157,7 @@ TEST(DownloadActionTest, TerminateEarlyTest) {
{
// takes ownership of passed in HttpFetcher
ObjectFeederAction<InstallPlan> feeder_action;
- InstallPlan install_plan(false, "", "", path, "");
+ InstallPlan install_plan(false, "", "", path);
feeder_action.set_obj(install_plan);
DownloadAction download_action(new MockHttpFetcher(&data[0], data.size()));
TerminateEarlyTestProcessorDelegate delegate;
@@ -231,12 +231,10 @@ gboolean PassObjectOutTestStarter(gpointer data) {
TEST(DownloadActionTest, PassObjectOutTest) {
GMainLoop *loop = g_main_loop_new(g_main_context_default(), FALSE);
- const string path("/tmp/DownloadActionTest");
-
// takes ownership of passed in HttpFetcher
InstallPlan install_plan(false, "",
- OmahaHashCalculator::OmahaHashOfString("x"), path,
- "");
+ OmahaHashCalculator::OmahaHashOfString("x"),
+ "/dev/null");
ObjectFeederAction<InstallPlan> feeder_action;
feeder_action.set_obj(install_plan);
DownloadAction download_action(new MockHttpFetcher("x", 1));
@@ -267,7 +265,7 @@ TEST(DownloadActionTest, BadOutFileTest) {
const string path("/fake/path/that/cant/be/created/because/of/missing/dirs");
// takes ownership of passed in HttpFetcher
- InstallPlan install_plan(false, "", "", path, "");
+ InstallPlan install_plan(false, "", "", path);
ObjectFeederAction<InstallPlan> feeder_action;
feeder_action.set_obj(install_plan);
DownloadAction download_action(new MockHttpFetcher("x", 1));

Powered by Google App Engine
This is Rietveld 408576698