chrome/common/extensions/extension_constants.h - Issue 545068: Allow extensions to add, remove, or change their page action popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_constants.h

Issue 545068: Allow extensions to add, remove, or change their page action popup. (Closed)

Patch Set: Rebase, to run trybots with test data in place. Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_constants.h

diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h

index c28c583edbaae544c245b5a4002880ba6ad7ca6a..113cfda310f83ff6e46a7bc4c2916238d485b288 100644

--- a/chrome/common/extensions/extension_constants.h

+++ b/chrome/common/extensions/extension_constants.h

@@ -32,6 +32,7 @@ namespace extension_manifest_keys {

extern const wchar_t* kPageActions;

extern const wchar_t* kPageActionIcons;

extern const wchar_t* kPageActionDefaultIcon;

+ extern const wchar_t* kPageActionDefaultPopup;

extern const wchar_t* kPageActionDefaultTitle;

extern const wchar_t* kPageActionPopup;

extern const wchar_t* kPageActionPopupHeight;

@@ -111,6 +112,7 @@ namespace extension_manifest_errors {

extern const char* kInvalidPageActionIconPath;

extern const char* kInvalidPageActionId;

extern const char* kInvalidPageActionDefaultTitle;

+ extern const char* kInvalidPageActionOldAndNewKeys;

extern const char* kInvalidPageActionPopup;

extern const char* kInvalidPageActionPopupHeight;

extern const char* kInvalidPageActionPopupPath;