Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9228)

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 545068: Allow extensions to add, remove, or change their page action popup. (Closed)
Patch Set: Rebase, to run trybots with test data in place. Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/page_action_apitest.cc ('k') | chrome/common/extensions/docs/pageAction.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api.json
diff --git a/chrome/common/extensions/api/extension_api.json b/chrome/common/extensions/api/extension_api.json
index 5a3e6c5aa0f579f29eb98098688e295f4f05ae55..80bf2312f93146fc0321ccb2c6a9e7896b7730d8 100755
--- a/chrome/common/extensions/api/extension_api.json
+++ b/chrome/common/extensions/api/extension_api.json
@@ -1002,13 +1002,31 @@
}
}
]
+ },
+ {
+ "name": "setPopup",
+ "type": "function",
+ "description": "Sets the html document to be opened as a popup when the user clicks on the page action's icon.",
+ "parameters": [
+ {
+ "name": "details",
+ "type": "object",
+ "properties": {
+ "tabId": {"type": "integer", "minimum": 0, "description": "The id of the tab for which you want to modify the page action."},
+ "popup": {
+ "type": "string",
+ "description": "The html file to show in a popup. If set to the empty string (''), no popup is shown."
+ }
+ }
+ }
+ ]
}
],
"events": [
{
"name": "onClicked",
"type": "function",
- "description": "Fired when a page action icon is clicked.",
+ "description": "Fired when a page action icon is clicked if the page action doesn't show a popup.",
"parameters": [
{
"name": "tab",
« no previous file with comments | « chrome/browser/extensions/page_action_apitest.cc ('k') | chrome/common/extensions/docs/pageAction.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698