Issue 5448001: Remove duplicate NotificationObserver mock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5448001: Remove duplicate NotificationObserver mock. (Closed)

Created:
10 years ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
danno

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove duplicate NotificationObserver mock. BUG=none TEST=Compiles and passes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67848

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -32 lines)			Patch
M	chrome/browser/password_manager/password_store_default_unittest.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_x_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/device_management_policy_provider_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/test/mock_notification_observer.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 2 (0 generated)

Mattias Nissler (ping if slow)

Looks like there already was a widely-used NotificationObserver mock implementation after all.

10 years ago (2010-12-01 11:26:02 UTC) #1

LGTM