Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 5444002: restart_in_chroot_if_needed can run scripts from bin/. cros_workon_now does this (Closed)

Created:
10 years ago by rochberg
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

restart_in_chroot_if_needed can run scripts from bin/. cros_workon_now does this BUG=chromium-os:9877 TEST=ran bin/cros_workon_now, cros_workon, set_shared_user_password Note---this introduces another bashism to common.sh. However, despite comments to the contrary, common.sh does not actually parse under dash without this change Change-Id: I1e6b9751afa8341c100f3b8e0b96284835a53d17 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3b91070

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment for ${var##pattern} construct #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M bin/cros_workon_make View 1 chunk +1 line, -1 line 0 comments Download
M common.sh View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rochberg
10 years ago (2010-12-01 21:00:26 UTC) #1
Chris Masone
lgtm w/comment nit http://codereview.chromium.org/5444002/diff/1/common.sh File common.sh (right): http://codereview.chromium.org/5444002/diff/1/common.sh#newcode241 common.sh:241: # $abspath minus everything up to ...
10 years ago (2010-12-01 21:18:51 UTC) #2
Chris Masone
And this doesn't require your other, abandoned change, does it? On 2010/12/01 21:18:51, Chris Masone ...
10 years ago (2010-12-01 21:19:18 UTC) #3
rochberg
10 years ago (2010-12-01 21:46:49 UTC) #4
Fixed comment.  

And you are correct---this is independent of the sudo mess.

Too late to push without a commit-and-run.  Will do so tom'w

Powered by Google App Engine
This is Rietveld 408576698