Move quoting of a JSON string to a specialized runtime function.

Move quoting of a JSON string to a specialized runtime function.

Previously used string replace regexp with function replacement.

[William Hesse, 2010-12-01 09:34:58]

LGTM.

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4618
src/runtime.cc:4618: if (sizeof(Char) > 1) {
1u?

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4632
src/runtime.cc:4632: // TODO(lrn): Better handling of allocation errors. Try
harder
I'm not sure this should be a TODO.  It may be better to always follow the
policy of failing on GC, and work on making this case rare, rather than inlining
it in many special places.

[William Hesse, 2010-12-01 09:36:56]

Still LGTM.

[Kevin Millikin (Chromium), 2010-12-01 09:44:51]

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4632
src/runtime.cc:4632: // TODO(lrn): Better handling of allocation errors. Try
harder
On 2010/12/01 09:34:58, William Hesse wrote:
> I'm not sure this should be a TODO.  It may be better to always follow the
> policy of failing on GC, and work on making this case rare, rather than
inlining
> it in many special places.

If you leave it as a TODO, please file an issue in the issue tracker and use the
bug number here instead of your username.

[Lasse Reichstein, 2010-12-01 10:02:47]

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4618
src/runtime.cc:4618: if (sizeof(Char) > 1) {
Done.

http://codereview.chromium.org/5443001/diff/1/src/runtime.cc#newcode4632
src/runtime.cc:4632: // TODO(lrn): Better handling of allocation errors. Try
harder
I'll remove it, and make a counter to count the extra work we do rescanning the
string. Then we can see whether this needs more attention.
It currently doesn't seem to be a problem.