chrome/browser/extensions/extension_prefs.cc - Issue 5441002: Clean up pref change notification handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 5441002: Clean up pref change notification handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix memory leaks in tests. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_prefs.cc

diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc

index 07195e42e189765006377726e936e68b8426f145..cbe2567e25993a31ca6658467604c21f908de582 100644

--- a/chrome/browser/extensions/extension_prefs.cc

+++ b/chrome/browser/extensions/extension_prefs.cc

@@ -326,7 +326,9 @@ void ExtensionPrefs::AddToExtensionPrefStringSet(

void ExtensionPrefs::SavePrefsAndNotify() {

prefs_->ScheduleSavePersistentPrefs();

- prefs_->pref_notifier()->OnUserPreferenceSet(kExtensionsPref);

+ // TODO(mnissler, danno): Don't use pref_notifier() here, but tell the

+ // PrefService by some other means that we changed the pref value.

+ prefs_->pref_notifier()->OnPreferenceChanged(kExtensionsPref);

}

bool ExtensionPrefs::IsBlacklistBitSet(DictionaryValue* ext) {