Clean up pref change notification handling.

chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/scoped_temp_dir.h"
 #include "base/scoped_vector.h"
-#include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/search_engines/search_engine_type.h"
 #include "chrome/browser/search_engines/search_terms_data.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
 #include "chrome/browser/search_engines/template_url_model.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/test/testing_pref_service.h"
 #include "chrome/test/testing_profile.h"
 #include "grit/theme_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 typedef testing::Test TemplateURLPrepopulateDataTest;
 
 const int kCountryIds[] = {
     'A'<<8|'D', 'A'<<8|'E', 'A'<<8|'F', 'A'<<8|'G', 'A'<<8|'I',
     'A'<<8|'L', 'A'<<8|'M', 'A'<<8|'N', 'A'<<8|'O', 'A'<<8|'Q',
     'A'<<8|'R', 'A'<<8|'S', 'A'<<8|'T', 'A'<<8|'U', 'A'<<8|'W',
@@ skipping 59 matching lines @@
       ASSERT_TRUE(unique_ids.find(urls[turl_i]->prepopulate_id()) ==
                   unique_ids.end());
       unique_ids.insert(urls[turl_i]->prepopulate_id());
     }
   }
 }
 
 // Verifies that default search providers from the preferences file
 // override the built-in ones.
 TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
-  const char pref_data[] =
-      "{ "
-      "  \"search_provider_overrides_version\":1,"
-      "  \"search_provider_overrides\": ["
-      "     { \"name\":\"foo\","
-      "       \"keyword\":\"fook\","
-      "       \"search_url\":\"http://foo.com/s?q={searchTerms}\","
-      "       \"favicon_url\":\"http://foi.com/favicon.ico\","
-      "       \"suggest_url\":\"\","
-      "       \"instant_url\":\"\","
-      "       \"encoding\":\"UTF-8\","
-      "       \"search_engine_type\":1,"
-      "       \"logo_id\":0,"
-      "       \"id\":1001"
-      "     }"
-      "   ]"
-      "}";
+  TestingPrefService prefs;
+  TemplateURLPrepopulateData::RegisterUserPrefs(&prefs);
+  prefs.SetUserPref(prefs::kSearchProviderOverridesVersion,
+                    Value::CreateIntegerValue(1));
+  ListValue* overrides = new ListValue;
+  DictionaryValue* entry = new DictionaryValue;
+  entry->SetString("name", "foo");
+  entry->SetString("keyword", "fook");
+  entry->SetString("search_url", "http://foo.com/s?q={searchTerms}");
+  entry->SetString("favicon_url", "http://foi.com/favicon.ico");
+  entry->SetString("suggest_url", "");
+  entry->SetString("instant_url", "");
+  entry->SetString("encoding", "UTF-8");
+  entry->SetInteger("search_engine_type", 1);
+  entry->SetInteger("logo_id", 0);
+  entry->SetInteger("id", 1001);
+  overrides->Append(entry);
+  prefs.SetUserPref(prefs::kSearchProviderOverrides, overrides);
 
-  ScopedTempDir temp_dir;
-  ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
-  FilePath preferences_file = temp_dir.path().AppendASCII("Preferences");
-  file_util::WriteFile(preferences_file, pref_data, sizeof(pref_data));
-
-  scoped_ptr<PrefService> prefs(
-      PrefService::CreateUserPrefService(preferences_file));
-  TemplateURLPrepopulateData::RegisterUserPrefs(prefs.get());
-
-  int version = TemplateURLPrepopulateData::GetDataVersion(prefs.get());
+  int version = TemplateURLPrepopulateData::GetDataVersion(&prefs);
   EXPECT_EQ(1, version);
 
   ScopedVector<TemplateURL> t_urls;
   size_t default_index;
   TemplateURLPrepopulateData::GetPrepopulatedEngines(
-      prefs.get(), &(t_urls.get()), &default_index);
+      &prefs, &(t_urls.get()), &default_index);
 
   ASSERT_EQ(1u, t_urls.size());
   EXPECT_EQ(L"foo", t_urls[0]->short_name());
   EXPECT_EQ(L"fook", t_urls[0]->keyword());
   EXPECT_EQ("foo.com", t_urls[0]->url()->GetHost());
   EXPECT_EQ("foi.com", t_urls[0]->GetFavIconURL().host());
   EXPECT_EQ(1u, t_urls[0]->input_encodings().size());
   EXPECT_EQ(1001, t_urls[0]->prepopulate_id());
   EXPECT_EQ(SEARCH_ENGINE_GOOGLE, t_urls[0]->search_engine_type());
   EXPECT_EQ(0, t_urls[0]->logo_id());
@@ skipping 47 matching lines @@
   EXPECT_EQ(kNoSearchEngineLogo,
             TemplateURLPrepopulateData::GetSearchEngineLogo(bad_engine));
   GURL engine_with_logo("http://www.ask.com/");
   EXPECT_EQ(IDR_SEARCH_ENGINE_LOGO_ASK,
             TemplateURLPrepopulateData::GetSearchEngineLogo(engine_with_logo));
   GURL engine_no_logo("http://araby.com/");
   EXPECT_EQ(kNoSearchEngineLogo,
             TemplateURLPrepopulateData::GetSearchEngineLogo(engine_no_logo));
 
 }