Clean up pref change notification handling.

chrome/browser/extensions/extension_proxy_api.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_proxy_api.h"
 
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_pref_store.h"
@@ skipping 61 matching lines @@
   dict->GetString("scheme", &proxy_server->scheme);
   EXTENSION_FUNCTION_VALIDATE(dict->GetString("host", &proxy_server->host));
   dict->GetInteger("port", &proxy_server->port);
   return true;
 }
 
 bool UseCustomProxySettingsFunction::ApplyAutoDetect(bool auto_detect) {
   // We take control of the auto-detect preference even if none was specified,
   // so that all proxy preferences are controlled by the same extension (if not
   // by a higher-priority source).
-  SendNotification(prefs::kProxyAutoDetect,
-                   Value::CreateBooleanValue(auto_detect));
+  scoped_ptr<Value> value(Value::CreateBooleanValue(auto_detect));
+  SendNotification(prefs::kProxyAutoDetect, value.get());
   return true;
 }
 
 bool UseCustomProxySettingsFunction::ApplyPacScript(DictionaryValue* pac_dict) {
   std::string pac_url;
   if (pac_dict)
     pac_dict->GetString("url", &pac_url);
 
   // We take control of the PAC preference even if none was specified, so that
   // all proxy preferences are controlled by the same extension (if not by a
   // higher-priority source).
-  SendNotification(prefs::kProxyPacUrl, Value::CreateStringValue(pac_url));
+  scoped_ptr<Value> value(Value::CreateStringValue(pac_url));
+  SendNotification(prefs::kProxyPacUrl, value.get());
   return true;
 }
 
 bool UseCustomProxySettingsFunction::ApplyProxyRules(
     DictionaryValue* proxy_rules) {
   if (!proxy_rules)
     return true;
 
   // Local data into which the parameters will be parsed. has_proxy describes
   // whether a setting was found for the scheme; proxy_dict holds the
@@ skipping 40 matching lines @@
       proxy_pref.append(proxy_server[i].scheme);
       proxy_pref.append("://");
       proxy_pref.append(proxy_server[i].host);
       if (proxy_server[i].port != ProxyServer::INVALID_PORT) {
         proxy_pref.append(":");
         proxy_pref.append(base::StringPrintf("%d", proxy_server[i].port));
       }
     }
   }
 
-  SendNotification(prefs::kProxyServer, Value::CreateStringValue(proxy_pref));
+  scoped_ptr<Value> value(Value::CreateStringValue(proxy_pref));
+  SendNotification(prefs::kProxyServer, value.get());
   return true;
 }
 
 void UseCustomProxySettingsFunction::SendNotification(const char* pref_path,
                                                       Value* pref_value) {
   ExtensionPrefStore::ExtensionPrefDetails details =
       std::make_pair(GetExtension(), std::make_pair(pref_path, pref_value));
 
   NotificationService::current()->Notify(
       NotificationType::EXTENSION_PREF_CHANGED,
       Source<Profile>(profile_),
       Details<ExtensionPrefStore::ExtensionPrefDetails>(&details));
 }