Clean up pref change notification handling.

chrome/browser/prefs/testing_pref_store.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_PREFS_DUMMY_PREF_STORE_H_
-#define CHROME_BROWSER_PREFS_DUMMY_PREF_STORE_H_
+#ifndef CHROME_TEST_TESTING_PREF_STORE_H_
+#define CHROME_TEST_TESTING_PREF_STORE_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
-#include "chrome/common/pref_store.h"
+#include "chrome/common/pref_store_base.h"
 
 class DictionaryValue;
 
-// |DummyPrefStore| is a stub implementation of the |PrefStore| interface.
-// It allows to get and set the state of the |PrefStore|.
-class DummyPrefStore : public PrefStore {
+// |TestingPrefStore| is a stub implementation of the |PrefStore| interface.
+// It allows to get and set the state of the |PrefStore| as well as triggering
+// notifications.
+class TestingPrefStore : public PrefStoreBase {
  public:
-  DummyPrefStore();
-  virtual ~DummyPrefStore() {}
+  TestingPrefStore();
+  virtual ~TestingPrefStore() {}
 
   virtual DictionaryValue* prefs() const { return prefs_.get(); }
 
   virtual PrefStore::PrefReadError ReadPrefs();
 
   virtual bool ReadOnly() { return read_only_; }
 
   virtual bool WritePrefs();
 
   // Getter and Setter methods for setting and getting the state of the
   // |DummyPrefStore|.
   virtual void set_read_only(bool read_only) { read_only_ = read_only; }
   virtual void set_prefs(DictionaryValue* prefs) { prefs_.reset(prefs); }
   virtual void set_prefs_written(bool status) { prefs_written_ = status; }
   virtual bool get_prefs_written() { return prefs_written_; }
 
+  // Publish these functions so tests can call them from the outside.
+  void NotifyPrefValueChanged(const std::string& key);
+  void NotifyInitializationCompleted();
+
  private:
   scoped_ptr<DictionaryValue> prefs_;
 
   // Flag that indicates if the PrefStore is read-only
   bool read_only_;
 
   // Flag that indicates if the method WritePrefs was called.
   bool prefs_written_;
 
-  DISALLOW_COPY_AND_ASSIGN(DummyPrefStore);
+  DISALLOW_COPY_AND_ASSIGN(TestingPrefStore);
 };
 
-#endif  // CHROME_BROWSER_PREFS_DUMMY_PREF_STORE_H_
+#endif  // CHROME_TEST_TESTING_PREF_STORE_H_