Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Issue 543146: Update maintainer script template (Closed)

Created:
10 years, 11 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
Reviewers:
tedbo
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Update maintainer script template

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/scripts/package_script_whitelist.sh View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vandebo (ex-Chrome)
10 years, 11 months ago (2010-01-21 02:58:36 UTC) #1
tedbo
http://codereview.chromium.org/543146/diff/1/2 File src/scripts/package_script_whitelist.sh (right): http://codereview.chromium.org/543146/diff/1/2#newcode99 src/scripts/package_script_whitelist.sh:99: Can you add a "set -e". I should have ...
10 years, 11 months ago (2010-01-21 04:43:52 UTC) #2
vandebo (ex-Chrome)
http://codereview.chromium.org/543146/diff/1/2 File src/scripts/package_script_whitelist.sh (right): http://codereview.chromium.org/543146/diff/1/2#newcode99 src/scripts/package_script_whitelist.sh:99: On 2010/01/21 04:43:52, tedbo wrote: > Can you add ...
10 years, 11 months ago (2010-01-21 05:16:48 UTC) #3
tedbo
10 years, 11 months ago (2010-01-21 05:19:59 UTC) #4
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698