A simple test for map compact.

A simple test for map compact.


Committed: http://code.google.com/p/v8/source/detail?r=3655

[antonm, 2010-01-19 13:05:17]

Søren,

may you have a look?

I am uneasy with this static variable to make test fast.  More v8y approach
might be to use a flag, but I'd resort to your judgment here.

[Søren Thygesen Gjesse, 2010-01-19 14:10:58]

I will suggest to putting this heap configuration into the Heap class together
with the "normal" heap confuguration like max_semispace_size_ /
MaxSemiSpaceSize(), and have a setter function for it whorking like
Heap::ConfigureHeap(int, int).

Also I suggest you call it max_map_space_pages_ / MaxMapSpacePages() /
SetMaxMapSpacePages(int).

Also on top of that adding a flag for it could be interesting as it would make
it easy to run all the tests with small map space - that could be interesting.
The following command runs all tests with the additional option
"--max-map-space-pages=64"

../tools/test.py --special-command "@ --max-map-space-pages=64" mode=debug

[antonm, 2010-01-19 16:16:43]

Thanks a lot for ideas, Søren.

I forgot about configuration point in Heap and it's definitely ways more
reasonable to do the work in here.

I didn't introduce another parameter for Heap::Configure as you suggested as
plain flag seems good enough for me, esp. given it's only needed for testing,
but if you prefer to see extended configuration, just let me know.

And thanks a lot for mentioning --special-command flag.

[Søren Thygesen Gjesse, 2010-01-19 16:20:20]

LGTM