Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 543105: Build and package candidate_window in addition to chrome. (Closed)

Created:
10 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
oshima
CC:
chromium-os-reviews_googlegroups.com, Yusuke Sato
Visibility:
Public.

Description

Build and package candidate_window in addition to chrome. candidate_window is used for entering text in CJK languages. See the design doc of "Chromium OS Text Input" for details: http://sites.google.com/a/chromium.org/dev/chromium-os/chromiumos-design-docs/text-input TEST=Ran "build_chrome.sh" and confirmed that candidate_window is included in chrome-chromeos.zip

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/scripts/build_chrome.sh View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
10 years, 11 months ago (2010-01-18 05:35:49 UTC) #1
oshima
This will not change the prebuild package that build bot builds. Is this what you ...
10 years, 11 months ago (2010-01-20 03:56:33 UTC) #2
satorux1
What did you mean by "the prebuild package"? Did you mean the pre-built chromium zip ...
10 years, 11 months ago (2010-01-20 04:03:49 UTC) #3
satorux1
10 years, 11 months ago (2010-01-20 08:17:46 UTC) #4
Got LGTM by mail. 

Mail discussion doesn't seem to update the code review page...

From: oshima <oshima@chromium.org>
Date: Wed, 20 Jan 2010 00:11:14 -0800
Message-ID: <c8fcecb31001200011h3a0586d6o4d878085383a0b20@mail.gmail.com>
Subject: Re: Build and package candidate_window in addition to chrome. 
	(issue543105)
To: Satoru Takabayashi <satorux@chromium.org>
Cc: chromium-os-reviews@googlegroups.com, yusukes@chromium.org


LGTM

On Tue, Jan 19, 2010 at 9:59 PM, Satoru Takabayashi <satorux@chromium.org>wrote:

> Thanks.
>
> Do you know how the latest ones are built, or who to contact?
>
>
I don't know who, but I guess one of nsylvan, davemoore or msb should know.

- oshima


> Anyway, I don't care much about the pre-built packages. As long as my
> change works for developers who build locally, it should be fine for now.
>
> Satoru
>
>
> On Wed, Jan 20, 2010 at 2:52 PM, oshima <oshima@chromium.org> wrote:
>
>> Sorry I wasn't clear. There are two pre-build packages, stable and latest.
>> The one you mentioned is the stable build,
>> and the link below is the latest ones.
>>
>> http://build.chromium.org/buildbot/snapshots/chromium-rel-linux-chromiumos
>>
>> see src/platform/chrome/copy_chrome_zip.sh
>>
>> I don't know about stable build, but I believe the latest one does not use
>> build_chrome.sh.
>>
>> - oshima
>>
>>

Powered by Google App Engine
This is Rietveld 408576698