Issue 543087: Fix build problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543087: Fix build problems. (Closed)

Created:
10 years, 11 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
=erik.corry, Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fix build problems. Committed: http://code.google.com/p/v8/source/detail?r=3622

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -37 lines)			Patch
	M	test/cctest/test-serialize.cc	View		2 chunks	+7 lines, -0 lines	1 comment	Download
	M	test/mjsunit/regress/regress-crbug-3184.js	View		1 chunk	+37 lines, -37 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

10 years, 11 months ago (2010-01-15 20:14:10 UTC) #2

LGTM.  Thanks a lot.

http://codereview.chromium.org/543087/diff/1/2
File test/cctest/test-serialize.cc (right):

http://codereview.chromium.org/543087/diff/1/2#newcode367
test/cctest/test-serialize.cc:367: #ifdef _MSC_VER
Can you add here a comment saying
// Avoid warning about unsafe fscanf from MSVC.

Expand Messages | Collapse Messages