The search terms are escaped using + or %20 for space depending on whether re...

The search terms are escaped using + or %20 for space depending on whether replacement is in query part of the URL or not.
Removed duplicate EscapeQueryParamValue functions without |use_plus| argument.

BUG=24571
TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36398

[whywhat, 2010-01-15 13:38:22]

Brett, I'm adding you as a reviewer because this change touches escape functions
that your TODOs intend to eliminate. Please, advise if I should use some other
way to escape here.

[sky, 2010-01-15 16:39:03]

The TemplateURL changes LGTM, but could you add a couple of tests for coverage
of the new code to template_url_unittest?

[brettw, 2010-01-15 17:54:50]

http://codereview.chromium.org/543077/diff/5002/5003
File net/base/escape.h (right):

http://codereview.chromium.org/543077/diff/5002/5003#newcode125
net/base/escape.h:125: string16* escaped, bool use_plus);
I'm not super excited about adding yet another overloaded version of this
function (and the later one). It looks like its not used too many places. Can
you just add "use_plus" to the previous one and update the callers?

The out param should be last, so use_plus should be the third argument.

[whywhat, 2010-01-15 18:13:17]

On 2010/01/15 16:39:03, sky wrote:
> The TemplateURL changes LGTM, but could you add a couple of tests for coverage
> of the new code to template_url_unittest?

Done.

[brettw, 2010-01-15 18:14:20]

LGTM

[whywhat, 2010-01-15 18:15:03]

http://codereview.chromium.org/543077/diff/5002/5003
File net/base/escape.h (right):

http://codereview.chromium.org/543077/diff/5002/5003#newcode125
net/base/escape.h:125: string16* escaped, bool use_plus);
On 2010/01/15 17:54:50, brettw wrote:
> I'm not super excited about adding yet another overloaded version of this
> function (and the later one). It looks like its not used too many places. Can
> you just add "use_plus" to the previous one and update the callers?

Sure. Done.
> 
> The out param should be last, so use_plus should be the third argument.

Done.