Issue 543067: linux: hack around arabic advances in harfbuzz

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543067: linux: hack around arabic advances in harfbuzz (Closed)

Created:
10 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: hack around arabic advances in harfbuzz Arabic vowels in some fonts (Times New Roman, at least) have non-zero advances, when they should be zero. Pango does a hack very similar to this to work around the same problem. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36418

Patch Set 1 #

Patch Set 2 : yay #

Patch Set 3 : with comments #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
M	third_party/harfbuzz/src/harfbuzz-arabic.c	View		1 chunk	+1 line, -0 lines	1 comment	Download
M	third_party/harfbuzz/src/harfbuzz-shaper.h	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	third_party/harfbuzz/src/harfbuzz-shaper.cpp	View	1 2	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

10 years, 11 months ago (2010-01-15 10:21:57 UTC) #2

LGTM

http://codereview.chromium.org/543067/diff/4001/4002
File third_party/harfbuzz/src/harfbuzz-arabic.c (right):

http://codereview.chromium.org/543067/diff/4001/4002#newcode1110
third_party/harfbuzz/src/harfbuzz-arabic.c:1110: item->shaperFlags |=
HB_ShaperFlag_ArabicHack;
Since this code is scheduled for demolition soon(ish) anyway, it's probably
moot, but I would call this ..._ForceMarksToZeroWidth or something. LGTM either
way.

Expand Messages | Collapse Messages