Issue 543045: Be more frugal with goats in these challenging economic times.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543045: Be more frugal with goats in these challenging economic times. (Closed)

Created:
10 years, 11 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google), Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Be more frugal with goats in these challenging economic times. BUG=31482 TEST=Use chrome for some time. Fewer goats should appear in bearontheroof's place. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36154

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : link to design doc #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	chrome/browser/task_manager.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/task_manager.cc	View	1 2	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

OK http://codereview.chromium.org/543045/diff/2001/3001 File chrome/browser/task_manager.cc (right): http://codereview.chromium.org/543045/diff/2001/3001#newcode173 chrome/browser/task_manager.cc:173: int goats_teleported = rand() & 15; nit: Why ...

10 years, 11 months ago (2010-01-13 18:47:41 UTC) #2

Nico

10 years, 11 months ago (2010-01-13 18:52:24 UTC) #3

Thanks, submitting.

http://codereview.chromium.org/543045/diff/2001/3002
File chrome/browser/task_manager.h (left):

http://codereview.chromium.org/543045/diff/2001/3002#oldcode389
chrome/browser/task_manager.h:389: // See design doc at http://go/at-teleporter
for more information.
On 2010/01/13 18:47:41, Paweł Hajdan Jr. wrote:
> Why did you remove the link to design doc? Please keep it.

Ooops! Added link back in cc file.

Expand Messages | Collapse Messages