Issue 543012: Add the capability to filter out files on try job with regexp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543012: Add the capability to filter out files on try job with regexp. (Closed)

Created:
10 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews_googlegroups.com, dglazkov

Visibility:
Public.

Description

Add the capability to filter out files on try job with regexp. By default, filters out 'ChangeLog'. A pain directly coming from Webkit. TEST=none BUG=none

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -9 lines)			Patch
M	scm.py	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/scm_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/trychange_unittest.py	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	trychange.py	View	4 chunks	+30 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 11 months ago (2010-01-12 04:39:12 UTC) #2

LGTM

http://codereview.chromium.org/543012/diff/1/6
File trychange.py (right):

http://codereview.chromium.org/543012/diff/1/6#newcode189
trychange.py:189: self.files = [
I think the style guide wants the braces tighter:
[blah for bleh in yuck
 if foo]

Expand Messages | Collapse Messages