Issue 543010: Port FastNewClosureStub introduced for ia32 in r3477 to x64 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543010: Port FastNewClosureStub introduced for ia32 in r3477 to x64 and arm. (Closed)

Created:
10 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port FastNewClosureStub introduced for ia32 in r3477 to x64 and arm. BUG=552 Committed: http://code.google.com/p/v8/source/detail?r=3578

Patch Set 3 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -20 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	2 chunks	+61 lines, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/mksnapshot.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2	2 chunks	+60 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/543010/diff/3001/3003 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/543010/diff/3001/3003#newcode2209 src/x64/codegen-x64.cc:2209: // Call the runtime to instantiate the function ...

10 years, 11 months ago (2010-01-12 06:25:15 UTC) #2

Mads Ager (chromium)

10 years, 11 months ago (2010-01-12 07:13:49 UTC) #3

http://codereview.chromium.org/543010/diff/3001/3003
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/543010/diff/3001/3003#newcode2209
src/x64/codegen-x64.cc:2209: // Call the runtime to instantiate the function
boilerplate
On 2010/01/12 06:25:15, Kasper Lund wrote:
> Maybe do the SyncRange outside the if and consistently use EmitPush in both
> paths?

Done in both x64 and ia32 versions.

Expand Messages | Collapse Messages

Issue 543010: Port FastNewClosureStub introduced for ia32 in r3477 to x64 and arm. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages