Issue 543009: WebKit roll to 53083

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543009: WebKit roll to 53083 (Closed)

Created:
10 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

WebKit roll to 53083 TBR=atwilson BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35919

Patch Set 1 #

Patch Set 2 : wontfix touch tests #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/kde/RegExp-expected.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/js/regexp-compile-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/kde/RegExp-expected.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/js/regexp-compile-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1	3 chunks	+7 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

10 years, 11 months ago (2010-01-11 19:06:45 UTC) #2

LGTM

http://codereview.chromium.org/543009/diff/2001/1002
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/543009/diff/2001/1002#newcode3145
webkit/tools/layout_tests/test_expectations.txt:3145: 
nit: white space at end of file.

Expand Messages | Collapse Messages