Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 5430006: Include the 5 most recent update engine logs, up to 2000 lines in chrome:system. (Closed)

Created:
10 years ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Include the 5 most recent update engine logs, up to 2000 lines in chrome:system. BUG=9786 TEST=looked at chrome:system after several reboots Change-Id: Id7ef94c6c1cb9ee22979a669f51c04b15d26f7b7 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=df3a466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M etc/sys_log_utils.lst View 1 chunk +1 line, -1 line 0 comments Download
M scripts/get_log View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years ago (2010-12-01 20:03:19 UTC) #1
adlr
10 years ago (2010-12-01 20:30:07 UTC) #2
LGTM

On Wed, Dec 1, 2010 at 12:03 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> Include the 5 most recent update engine logs, up to 2000 lines in
> chrome:system.
>
> BUG=9786
> TEST=looked at chrome:system after several reboots
>
> Change-Id: Id7ef94c6c1cb9ee22979a669f51c04b15d26f7b7
>
> Please review this at http://codereview.chromium.org/5430006/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/userfeedback.git@master
>
> Affected files:
>  M etc/sys_log_utils.lst
>  M scripts/get_log
>
>
> Index: etc/sys_log_utils.lst
> diff --git a/etc/sys_log_utils.lst b/etc/sys_log_utils.lst
> index
>
786a86e8acfbc313b908aae4ef946f0d97acda15..49a2a2648c9628a861c9468240a5afb5631f3b4d
> 100755
> --- a/etc/sys_log_utils.lst
> +++ b/etc/sys_log_utils.lst
> @@ -41,5 +41,5 @@ syslog,/usr/share/userfeedback/scripts/getmsgs --last '2
> hours' /var/log/message
>  touchpad,/opt/google/touchpad/tpcontrol status
>  ui_log,/usr/share/userfeedback/scripts/get_log /var/log/ui/ui.LATEST
>  uname,/bin/uname -a
> -update_engine.log,/usr/share/userfeedback/scripts/get_log
> /var/log/update_engine.log
> +update_engine.log,cat $(ls -1tr /var/log/update_engine | tail -5 | sed
> s.^./var/log/update_engine/.) | /usr/share/userfeedback/scripts/get_log
> /dev/stdin 2000
>  verified boot,/usr/share/userfeedback/scripts/get_log
> /tmp/debug_vboot/noisy.log
> Index: scripts/get_log
> diff --git a/scripts/get_log b/scripts/get_log
> index
>
ff6dc8111871cbc286e2b39af6c1917ed05cdcaa..0393733b24d84108950f6ad27223f0afe9953f5a
> 100755
> --- a/scripts/get_log
> +++ b/scripts/get_log
> @@ -9,8 +9,10 @@
>  # with empty entries that just look broken.
>
>  max_lines=${2:-1000}
> -
>  file=$1
> +
> +[ "$file" = "/dev/stdin" ] && tail --lines=$max_lines "$file" && exit
> +
>  if [ -h "$file" ]; then
>   file="$(readlink -f $file)"
>  fi
>
>
>

Powered by Google App Engine
This is Rietveld 408576698