Refactored cookies persistent store clean-up on shutdown.

chrome/browser/net/sqlite_persistent_cookie_store.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A sqlite implementation of a cookie monster persistent store.
 
 #ifndef CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_
 #define CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "app/sql/meta_table.h"
 #include "base/file_path.h"
 #include "base/ref_counted.h"
 #include "net/base/cookie_monster.h"
 
 namespace sql {
 class Connection;
 }
 
 class FilePath;
 
+// Implements the PersistentCookieStore interface in terms of a SQLite database.
+// For documentation about the actual member functions consult the documentation
+// of the parent class |net::CookieMonster::PersistentCookieStore|.
 class SQLitePersistentCookieStore
     : public net::CookieMonster::PersistentCookieStore {
  public:
   explicit SQLitePersistentCookieStore(const FilePath& path);
   virtual ~SQLitePersistentCookieStore();
 
-  virtual bool Load(std::vector<net::CookieMonster::CanonicalCookie*>*);
+  virtual bool Load(std::vector<net::CookieMonster::CanonicalCookie*>* cookies);
 
-  virtual void AddCookie(const net::CookieMonster::CanonicalCookie&);
+  virtual void AddCookie(const net::CookieMonster::CanonicalCookie& cc);
   virtual void UpdateCookieAccessTime(
-      const net::CookieMonster::CanonicalCookie&);
-  virtual void DeleteCookie(const net::CookieMonster::CanonicalCookie&);
+      const net::CookieMonster::CanonicalCookie& cc);
+  virtual void DeleteCookie(const net::CookieMonster::CanonicalCookie& cc);
 
-  static void ClearLocalState(const FilePath& path);
+  void SetClearLocalStateOnExit(bool clear_local_state) {

[jochen (gone - plz use gerrit), 2010/12/02 16:48:44]

virtual

[pastarmovj, 2010/12/03 16:43:02]

Done.

+    clear_local_state_on_exit_ = clear_local_state;
+  }
 
  private:
   class Backend;
 
   // Database upgrade statements.
   bool EnsureDatabaseVersion(sql::Connection* db);
 
   FilePath path_;
   scoped_refptr<Backend> backend_;
 
+  // If true the persistent store should be deleted upon destruction.

[jochen (gone - plz use gerrit), 2010/12/02 16:48:44]

True if ..

[pastarmovj, 2010/12/03 16:43:02]

Done.

+  bool clear_local_state_on_exit_;
+
   sql::MetaTable meta_table_;
 
   DISALLOW_COPY_AND_ASSIGN(SQLitePersistentCookieStore);
 };
 
 #endif  // CHROME_BROWSER_NET_SQLITE_PERSISTENT_COOKIE_STORE_H_