Issue 5423002: Help make base compile under NaCl...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5423002: Help make base compile under NaCl... (Closed)

Created:
10 years ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
brettw, eseidel

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, eseidel1

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Help make base compile under NaCl This file requires a few tweaks to run under Native Client. For example, there isn't a NaCl API to determine whether the process is being debugged and int3 isn't a valid NaCl instruction. Original patch by Eric Seidel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67827

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	base/debug/debugger_posix.cc	View		3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

http://code.google.com/p/nativeclient/issues/detail?id=645 is the NaCl issue about int3. Might want to mention that in the diff.

10 years ago (2010-12-01 07:05:07 UTC) #2

eseidel

On 2010/12/01 07:05:07, Eric Seidel (Google) wrote: > http://code.google.com/p/nativeclient/issues/detail?id=645 is the NaCl issue > about ...

10 years ago (2010-12-01 07:05:24 UTC) #3

brettw

On Tue, Nov 30, 2010 at 11:05 PM, <eseidel@chromium.org> wrote: > http://code.google.com/p/nativeclient/issues/detail?id=645 is the NaCl ...

10 years ago (2010-12-01 07:24:39 UTC) #4

abarth-chromium

10 years ago (2010-12-01 07:37:49 UTC) #5

On Tue, Nov 30, 2010 at 11:24 PM, Brett Wilson <brettw@chromium.org> wrote:
> On Tue, Nov 30, 2010 at 11:05 PM,  <eseidel@chromium.org> wrote:
>> http://code.google.com/p/nativeclient/issues/detail?id=645 is the NaCl issue
>> about int3.  Might want to mention that in the diff.
>
> I agree. LGTM with that.

Ok.  I put it as a comment in the code instead of in the commit message.

Adam

Expand Messages | Collapse Messages