Update minijail tests with real mocks and packaging testing deps

Update minijail tests with real mocks and packaging testing deps
- Now needs gmock, gtest, and chromeos-microbenchmark
- Adds mocks for options, interface, and env
- Adds baseline tests for minijail and testing of default options functionality
- Makes minijail failures non-terminal

[Chris Masone, 2010-01-19 22:30:54]

I had some nits on the first version.

Once those are cleared up, lgtm

http://codereview.chromium.org/542124/diff/1/6
File src/platform/minijail/minijail_unittest.cc (right):

http://codereview.chromium.org/542124/diff/1/6#newcode75
src/platform/minijail/minijail_unittest.cc:75: ::testing::Sequence pids, vfs;
you never put anything in these Sequences...I'm a bit of a gmock noob, though,
so maybe there's magic going on.

http://codereview.chromium.org/542124/diff/1/6#newcode93
src/platform/minijail/minijail_unittest.cc:93: ::testing::Sequence pids, vfs;
see above comment, re: magic

http://codereview.chromium.org/542124/diff/1/6#newcode111
src/platform/minijail/minijail_unittest.cc:111: ::testing::Sequence pids, vfs;
moar magic?

http://codereview.chromium.org/542124/diff/1/8
File src/platform/minijail/mock_interface.h (right):

http://codereview.chromium.org/542124/diff/1/8#newcode4
src/platform/minijail/mock_interface.h:4: // Some portions Copyright (c) 2009
The Chromium Authors.
OS authors?  or Chromium?

http://codereview.chromium.org/542124/diff/1/10
File src/platform/minijail/options_unittest.cc (right):

http://codereview.chromium.org/542124/diff/1/10#newcode71
src/platform/minijail/options_unittest.cc:71: .WillOnce(Return(true));
toss this line?

[Will Drewry, 2010-01-19 22:38:03]

Done.

http://codereview.chromium.org/542124/diff/1/6
File src/platform/minijail/minijail_unittest.cc (right):

http://codereview.chromium.org/542124/diff/1/6#newcode75
src/platform/minijail/minijail_unittest.cc:75: ::testing::Sequence pids, vfs;
On 2010/01/19 22:30:54, cmasone wrote:
> you never put anything in these Sequences...I'm a bit of a gmock noob, though,
> so maybe there's magic going on.

nope  left over from some testing I forgot about. BALEETED.

http://codereview.chromium.org/542124/diff/1/6#newcode93
src/platform/minijail/minijail_unittest.cc:93: ::testing::Sequence pids, vfs;
On 2010/01/19 22:30:54, cmasone wrote:
> see above comment, re: magic

Done.

http://codereview.chromium.org/542124/diff/1/6#newcode111
src/platform/minijail/minijail_unittest.cc:111: ::testing::Sequence pids, vfs;
On 2010/01/19 22:30:54, cmasone wrote:
> moar magic?

Done.

http://codereview.chromium.org/542124/diff/1/8
File src/platform/minijail/mock_interface.h (right):

http://codereview.chromium.org/542124/diff/1/8#newcode4
src/platform/minijail/mock_interface.h:4: // Some portions Copyright (c) 2009
The Chromium Authors.
On 2010/01/19 22:30:54, cmasone wrote:
> OS authors?  or Chromium?

Removed.  Some parts of the env code was from Chromium, but not anything else. 
I had cut'n'pasted the boilerplate. Doh.

http://codereview.chromium.org/542124/diff/1/10
File src/platform/minijail/options_unittest.cc (right):

http://codereview.chromium.org/542124/diff/1/10#newcode71
src/platform/minijail/options_unittest.cc:71: .WillOnce(Return(true));
On 2010/01/19 22:30:54, cmasone wrote:
> toss this line?

Done.

[Chris Masone, 2010-01-19 22:42:16]

On 2010/01/19 22:38:03, Will Drewry wrote:
> Done.
> 
> http://codereview.chromium.org/542124/diff/1/6
> File src/platform/minijail/minijail_unittest.cc (right):
> 
> http://codereview.chromium.org/542124/diff/1/6#newcode75
> src/platform/minijail/minijail_unittest.cc:75: ::testing::Sequence pids, vfs;
> On 2010/01/19 22:30:54, cmasone wrote:
> > you never put anything in these Sequences...I'm a bit of a gmock noob,
though,
> > so maybe there's magic going on.
> 
> nope  left over from some testing I forgot about. BALEETED.
> 
> http://codereview.chromium.org/542124/diff/1/6#newcode93
> src/platform/minijail/minijail_unittest.cc:93: ::testing::Sequence pids, vfs;
> On 2010/01/19 22:30:54, cmasone wrote:
> > see above comment, re: magic
> 
> Done.
> 
> http://codereview.chromium.org/542124/diff/1/6#newcode111
> src/platform/minijail/minijail_unittest.cc:111: ::testing::Sequence pids, vfs;
> On 2010/01/19 22:30:54, cmasone wrote:
> > moar magic?
> 
> Done.
> 
> http://codereview.chromium.org/542124/diff/1/8
> File src/platform/minijail/mock_interface.h (right):
> 
> http://codereview.chromium.org/542124/diff/1/8#newcode4
> src/platform/minijail/mock_interface.h:4: // Some portions Copyright (c) 2009
> The Chromium Authors.
> On 2010/01/19 22:30:54, cmasone wrote:
> > OS authors?  or Chromium?
> 
> Removed.  Some parts of the env code was from Chromium, but not anything else.

> I had cut'n'pasted the boilerplate. Doh.
> 
> http://codereview.chromium.org/542124/diff/1/10
> File src/platform/minijail/options_unittest.cc (right):
> 
> http://codereview.chromium.org/542124/diff/1/10#newcode71
> src/platform/minijail/options_unittest.cc:71: .WillOnce(Return(true));
> On 2010/01/19 22:30:54, cmasone wrote:
> > toss this line?
> 
> Done.

lgtm