Issue 542112: Fix some usage of "this" in builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542112: Fix some usage of "this" in builtins (Closed)

Created:
10 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix some usage of "this" in builtins The implementation of Object.prototype.valueOf and Object.prototype.toString now calls ToObject on "this" as mandated by the spec. Committed: http://code.google.com/p/v8/source/detail?r=3651

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -4 lines)			Patch
M	src/arm/codegen-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/codegen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/macros.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/v8natives.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	test/mjsunit/value-wrapper.js	View	1 2	3 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/542112/diff/2001/2002 File test/mjsunit/value-wrapper.js (right): http://codereview.chromium.org/542112/diff/2001/2002#newcode81 test/mjsunit/value-wrapper.js:81: for (var i = 0; i < 10; ...

10 years, 11 months ago (2010-01-19 13:57:05 UTC) #2

Søren Thygesen Gjesse

10 years, 11 months ago (2010-01-19 14:14:44 UTC) #3

http://codereview.chromium.org/542112/diff/2001/2002
File test/mjsunit/value-wrapper.js (right):

http://codereview.chromium.org/542112/diff/2001/2002#newcode81
test/mjsunit/value-wrapper.js:81: for (var i = 0; i < 10; i++) {
On 2010/01/19 13:57:05, Lasse Reichstein wrote:
> Put a comment somewhere in this file explaining why these tests are in a loop.

Done.

Expand Messages | Collapse Messages