Issue 542105: Fix a bug in the short-circuit logical operations in the toplevel...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542105: Fix a bug in the short-circuit logical operations in the toplevel... (Closed)

Created:
10 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix a bug in the short-circuit logical operations in the toplevel code generator. Committed: http://code.google.com/p/v8/source/detail?r=3636

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+221 lines, -41 lines)			Patch
M	src/ia32/fast-codegen-ia32.cc	View	1	10 chunks	+112 lines, -20 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	1	7 chunks	+108 lines, -20 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

When performing the inlined comparisons before calling the ToBoolean stub on ia32 and x64, there ...

10 years, 11 months ago (2010-01-18 15:43:28 UTC) #1

LGTM.