Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 542104: Fix windows tests. In the context of fopen the opposite of 'b' for binary... (Closed)

Created:
10 years, 11 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix windows tests. In the context of fopen the opposite of 'b' for binary is '' for ascii, not 'a' for ascii. Committed: http://code.google.com/p/v8/source/detail?r=3628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 11 months ago (2010-01-18 11:34:19 UTC) #1
Lasse Reichstein
10 years, 11 months ago (2010-01-18 11:57:20 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698