Issue 542097: Move is_whitelisted to the common script so that all users get the previous fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542097: Move is_whitelisted to the common script so that all users get the previous fix (Closed)

Created:
10 years, 11 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_googlegroups.com, tedbo

Visibility:
Public.

Description

Move is_whitelisted to the common script so that all users get the previous fix Fix typo to enable preinst scripts to run

Patch Set 2 : Correct inconsistent versions of is_whitelisted #

Total comments: 2

Patch Set 3 : Fix silent failure case #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -27 lines)			Patch
M	src/scripts/common.sh	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/scripts/dpkg_no_scripts.sh	View	1 2	3 chunks	+3 lines, -14 lines	0 comments	Download
M	src/scripts/package_script_whitelist.sh	View		1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ comment. i see you're just moving code, it's okay to keep it, but ...

10 years, 11 months ago (2010-01-16 03:37:39 UTC) #2

vandebo (ex-Chrome)

Comment addressed, submitting. http://codereview.chromium.org/542097/diff/1001/2001 File src/scripts/common.sh (right): http://codereview.chromium.org/542097/diff/1001/2001#newcode200 src/scripts/common.sh:200: test -f "$whitelist" || return On ...

10 years, 11 months ago (2010-01-16 03:43:44 UTC) #3

LGTM