Issue 542092: Submit Object.getOwnPropertyNames patch by Pavel Feldman. See http://codereview.chromium.org/549050.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542092: Submit Object.getOwnPropertyNames patch by Pavel Feldman. See http://codereview.chromium.org/549050. (Closed)

Created:
10 years, 11 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Submit Object.getOwnPropertyNames patch by Pavel Feldman. See http://codereview.chromium.org/549050. Add copyright to regression test to fix build broken by r3619. TBR=sgjesse@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=3620

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+339 lines, -172 lines)			Patch
M	src/messages.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/mirror-delay.js	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+150 lines, -150 lines	0 comments	Download
M	src/v8natives.js	View	3 chunks	+46 lines, -9 lines	0 comments	Download
A	test/mjsunit/object-get-own-property-names.js	View	1 chunk	+104 lines, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-crbug-3184.js	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Thygesen Gjesse

On 2010/01/15 15:33:26, Michail Naganov wrote: >

10 years, 11 months ago (2010-01-18 08:12:47 UTC) #2

Søren Thygesen Gjesse

10 years, 11 months ago (2010-01-18 08:13:11 UTC) #3

LGTM

Thanks for adding the copyright header.