Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Issue 542079: build: Add gnupg and x11-utils to prod package list. (Closed)

Created:
10 years, 11 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

build: Add gnupg and x11-utils to prod package list. apt-get can't verify signatures without GPG, which leads to devserver scripts breaking. xwininfo and xprop are useful for debugging X issues.

Patch Set 1 #

Total comments: 1

Patch Set 2 : make package-installing scripts support end-of-line comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/package_repo/package-list-prod.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M src/scripts/install_packages.sh View 1 chunk +1 line, -1 line 0 comments Download
M src/scripts/make_chroot.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
10 years, 11 months ago (2010-01-14 18:52:05 UTC) #1
Chris Masone
http://codereview.chromium.org/542079/diff/1/2 File src/package_repo/package-list-prod.txt (right): http://codereview.chromium.org/542079/diff/1/2#newcode40 src/package_repo/package-list-prod.txt:40: gnupg # needed by apt-get to verify signatures did ...
10 years, 11 months ago (2010-01-14 20:30:39 UTC) #2
Daniel Erat
The comment that I added to the gnupg line didn't get handled correctly by the ...
10 years, 11 months ago (2010-01-15 03:23:49 UTC) #3
Chris Masone
10 years, 11 months ago (2010-01-15 03:26:59 UTC) #4
On 2010/01/15 03:23:49, Daniel Erat wrote:
> The comment that I added to the gnupg line didn't get handled correctly by the
> package-installing script, but I've updated that script and the corresponding
> one for the chroot now.

lgtm

Powered by Google App Engine
This is Rietveld 408576698