Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 542068: Enhance autotest run inside chroot. (Closed)

Created:
10 years, 11 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_googlegroups.com
Visibility:
Public.

Description

Enhance autotest run inside chroot.

Patch Set 1 #

Patch Set 2 : patch1 #

Patch Set 3 : code review. #

Patch Set 4 : remove make_autotest out from make_chroot. #

Patch Set 5 : revert changes made to make_chroot.sh. #

Patch Set 6 : minor change. #

Total comments: 1

Patch Set 7 : format changes only. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/scripts/make_autotest.sh View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M src/scripts/run_autotest.sh View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ericli
10 years, 11 months ago (2010-01-14 01:05:33 UTC) #1
petkov
Per our discussion offline, we probably shouldn't run make_autotest as part of make_chroot.
10 years, 11 months ago (2010-01-14 05:53:40 UTC) #2
petkov
LGTM if you fix the comment below. Are we still planning to merge this with ...
10 years, 11 months ago (2010-01-15 17:47:10 UTC) #3
ericli
10 years, 11 months ago (2010-01-15 18:08:06 UTC) #4
Fixed.

Yes, that is still the plan.

Sean will work with kmixter on the merge after he moved down to MTV. Next week.

submitting.

Powered by Google App Engine
This is Rietveld 408576698