Re-work automation setup scripts.

Re-work automation setup scripts.

[ericli, 2010-01-13 18:41:26]

need some more work.

http://codereview.chromium.org/542058/diff/1/2
File src/scripts/make_autotest.sh (right):

http://codereview.chromium.org/542058/diff/1/2#newcode8
src/scripts/make_autotest.sh:8: # The idea is to compile any platform-dependent
autotest client tests in the build
reformat for 80char width.

http://codereview.chromium.org/542058/diff/1/2#newcode36
src/scripts/make_autotest.sh:36: sudo cp -rp ${AUTOTEST_SRC}/* ${AUTOTEST_DEST}
You dont need to copy everything into chroot, e.g. frontend, database.

This is sufficient.
{client,conmux,server,tko,utils,global_config.ini,shadow_config.ini}

http://codereview.chromium.org/542058/diff/1/2#newcode38
src/scripts/make_autotest.sh:38: sudo mkdir -p ${AUTOTEST_DEST}
duplicated with line 35, 36.

http://codereview.chromium.org/542058/diff/1/2#newcode61
src/scripts/make_autotest.sh:61: server/autoserv client/site_tests/setup/control
This should be 
client/bin/autotest client/site_tests/setup/control

[seano, 2010-01-13 18:50:17]

Addressing the stuff I missed.

I'll send a further CL to integrate with kmixter's autotest runner scripts, and
remove duplicate functionality.

http://codereview.chromium.org/542058/diff/1/2
File src/scripts/make_autotest.sh (right):

http://codereview.chromium.org/542058/diff/1/2#newcode8
src/scripts/make_autotest.sh:8: # The idea is to compile any platform-dependent
autotest client tests in the build
On 2010/01/13 18:41:26, ericli wrote:
> reformat for 80char width.

Done.

http://codereview.chromium.org/542058/diff/1/2#newcode36
src/scripts/make_autotest.sh:36: sudo cp -rp ${AUTOTEST_SRC}/* ${AUTOTEST_DEST}
On 2010/01/13 18:41:26, ericli wrote:
> You dont need to copy everything into chroot, e.g. frontend, database.
> 
> This is sufficient.
> {client,conmux,server,tko,utils,global_config.ini,shadow_config.ini}

Done.

http://codereview.chromium.org/542058/diff/1/2#newcode38
src/scripts/make_autotest.sh:38: sudo mkdir -p ${AUTOTEST_DEST}
On 2010/01/13 18:41:26, ericli wrote:
> duplicated with line 35, 36.

Had several dupe lines in there, fixed.

[ericli, 2010-01-13 18:59:38]

On 2010/01/13 18:58:01, seano wrote:
> 

LTGM.

[petkov, 2010-01-13 20:13:40]

LGTM but fix the line length.

http://codereview.chromium.org/542058/diff/7001/2002
File src/scripts/make_autotest.sh (right):

http://codereview.chromium.org/542058/diff/7001/2002#newcode38
src/scripts/make_autotest.sh:38: cp -rpf
${CHROOT_TRUNK_DIR}/src/third_party/autotest/files/{client,server,tko,utils,global_config.ini,shadow_config.ini}
${AUTOTEST_DEST}
80 characters