Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_network_transaction.cc

Issue 542029: Retry proxies which were cached as bad before giving up.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_error_list.h ('k') | net/proxy/proxy_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction.cc
===================================================================
--- net/http/http_network_transaction.cc (revision 35979)
+++ net/http/http_network_transaction.cc (working copy)
@@ -611,14 +611,9 @@
// http://www.chromium.org/developers/design-documents/proxy-settings-fallback
if (proxy_info_.is_empty()) {
- // No proxies/direct to choose from. This can happen when:
- // a. We don't support any of the proxies in the returned list.
- // b. The proxy service returned us an empty list.
- // 1. this can happen if all the proxies were marked as bad already.
- //
- // TODO(eroman): in case (b.1) it would be better to just try the bad
- // proxies again rather than failing without having tried anything!
- return ERR_EMPTY_PROXY_LIST;
+ // No proxies/direct to choose from. This happens when we don't support any
+ // of the proxies in the returned list.
+ return ERR_NO_SUPPORTED_PROXIES;
}
if (result != OK) {
« no previous file with comments | « net/base/net_error_list.h ('k') | net/proxy/proxy_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698