Issue 542007: Fixed issue with try where patchset is passed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542007: Fixed issue with try where patchset is passed.... (Closed)

Created:
10 years, 11 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fixed issue with try where patchset is passed. The new try execution should only be triggered when a user just passes the rietveld issue number. Usually, if your branch has a working patchset already defined, it shouldn't think the user passed it. The code has been updated to force patchset to be None (not 0 or any other number) so that specific occurence wont happen again. TBR=maruel BUG=None TEST=git try, git try --issue=123, git try --issue=123 --patchset=0, should all work fine now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35889

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	trychange.py	View		1 chunk	+1 line, -1 line	0 comments	Download