Issue 542005: Hooked demos.gyp and gles_book_examples.gyp to all.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542005: Hooked demos.gyp and gles_book_examples.gyp to all.gyp (Closed)

Created:
10 years, 11 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
Vangelis Kokkevis, apatrick, apatrick_chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hooked demos.gyp and gles_book_examples.gyp to all.gyp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35865

Patch Set 1 #

Total comments: 2

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/all.gyp	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick

LGTM http://codereview.chromium.org/542005/diff/1/2 File build/all.gyp (right): http://codereview.chromium.org/542005/diff/1/2#newcode99 build/all.gyp:99: '../gpu/demos/demos.gyp:*', It looks like these are in alphabetical ...

10 years, 11 months ago (2010-01-09 03:57:08 UTC) #3

alokp

10 years, 11 months ago (2010-01-09 04:16:35 UTC) #4

http://codereview.chromium.org/542005/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/542005/diff/1/2#newcode99
build/all.gyp:99: '../gpu/demos/demos.gyp:*',
On 2010/01/09 03:57:08, apatrick wrote:
> It looks like these are in alphabetical order, in which case demos.gyp should
be
> one line up.

Done.

Expand Messages | Collapse Messages