Issue 5414001: Remove more broken urlparse.urljoin examples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5414001: Remove more broken urlparse.urljoin examples. (Closed)

Created:
10 years ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
diandersAtChromium, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Remove more broken urlparse.urljoin examples. urlparse.urljoin('scheme:foo/bar/', 'baz') == 'baz', so it doesn't work the way I expected. Instead, let's use regular string joins. TBR, because the tree is broken as a result. BUG=chromium-os:5311 TEST=Examine example Packages file, run buildbot. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2df2dd5

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	chromite/lib/binpkg.py	View		4 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages